[codex] Fix internal LongBridge precheck invoke#171
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dd4aa6b7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ "${attempt_seen}" = "true" ]; then | ||
| if [ -n "${status_code}" ] && [ "${status_code}" != "0" ]; then | ||
| echo "Cloud Scheduler job ${scheduler_job} failed with status ${status_code}: ${status_message}" >&2 | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Cloud Scheduler documents lastAttemptTime as the time an attempt started and status as the target response for the last attempted execution, so for /precheck runs that take more than a moment this branch can fire before the Cloud Run request has completed (or while status is still empty/stale from a previous run). Because an empty status is treated as success and the loop exits, the workflow can pass even if the forced scheduler invocation later returns 500; keep polling until the new attempt has a populated terminal status.
Useful? React with 👍 / 👎.
1 participant
Summary
/precheckvalidation notifications as strategy prechecks instead of heartbeat messagesFixes #168.
Validation
Note: full
tests.test_notificationswas not run locally because this VPS does not have pandas installed; CI installs the repo dependencies.